Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drill Output][Added] Option to omit generation of drill files #720

Merged
merged 1 commit into from
Nov 14, 2024
Merged

[Drill Output][Added] Option to omit generation of drill files #720

merged 1 commit into from
Nov 14, 2024

Conversation

nguyen-v
Copy link

@nguyen-v nguyen-v commented Nov 13, 2024 •
edited
Loading

This PR adds the generate_drill_files option (default True) to the gerb_drill and excellon outputs. This is useful when one wants to only generate the drill map without drill files.

@set-soft set-soft merged commit bc67b2f into INTI-CMNB:dev Nov 14, 2024
17 checks passed
@set-soft
Copy link
Member

Ok, thanks!

@set-soft
Copy link
Member

Just a couple of comments:

  1. You don't need to add it to excellon and gerb_drill, both are "any_drill"
  2. You don't need to modify the RST files, they are generated from the source code using "make doc"

@nguyen-v
Copy link
Author

Just a couple of comments:

  1. You don't need to add it to excellon and gerb_drill, both are "any_drill"
  2. You don't need to modify the RST files, they are generated from the source code using "make doc"

Good to know, will take note for any future PR

@nguyen-v nguyen-v deleted the excellon_generate_drill_opt branch November 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nguyen-v @set-soft